Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on MSMQ bridge specifics #6812

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

jpalac
Copy link
Contributor

@jpalac jpalac commented Aug 22, 2024

Update the documentation to:

  • remove refence to @machine in the QueueAddress
  • specify that the bridge needs to be installed on each MSMQ server

@andreasohlund andreasohlund marked this pull request as draft August 23, 2024 06:17
@@ -196,9 +196,9 @@ public void QueueName()
#region custom-address

var transport = new BridgeTransport(new MsmqTransport());
transport.HasEndpoint("Finance", "finance_queue_name");
transport.HasEndpoint("Finance", "finance@machinename");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should keep both examples:

  1. Where the endpoint is on a different machine => finance@machinename
  2. Where the queue name is different due to https://docs.particular.net/nservicebus/endpoints/specify-endpoint-name#input-queue being used? => finance_queue_name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And perhaps spell out that 1 is MSMQ specific and that 2 applies to all transports?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where the queue name is different due to https://docs.particular.net/nservicebus/endpoints/specify-endpoint-name#input-queue being used? => finance_queue_name

I've realized that my statement here is wrong, the address override should only be used to control where messages get dispatched to and where subscription messages are sent.

To control the name of the queue that the bridge reads from the endpoint name has to be adjusted since that is what we pass into the raw endpoint that does the reading.

https://github.com/Particular/NServiceBus.MessagingBridge/blob/master/src/NServiceBus.MessagingBridge/EndpointProxyFactory.cs#L28

In short: The text in this PR is ok even though I'm not sure if "machinename" is better than "another-machine"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought perhaps this PR is no longer relevant since we fixed it so that you can specify the machine name in the queue address, and we decided that just specifying a queue name isn't really supported?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, so we can close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants